materialize: remove deprecated constraints from materialize protocol#3104
Open
mdibaiee wants to merge 2 commits into
Open
materialize: remove deprecated constraints from materialize protocol#3104mdibaiee wants to merge 2 commits into
constraints from materialize protocol#3104mdibaiee wants to merge 2 commits into
Conversation
The `test_field_selection` wasm test and the FIELD_SELECTION.md example still supplied connector constraints via the removed `constraints` map. After removing that field, the map is silently dropped on deserialization, so every field became ConnectorOmits and the assertion failed. Switch the fixture and doc to the equivalent `projectionConstraints` list form. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
williamhbaker
left a comment
williamhbaker
left a comment
Member
There was a problem hiding this comment.
For dekaf, I believe we need to first deploy it everywhere (all data planes + the remaining k8s deployment, IIRC) with its updated code to only emit ProjectionConstraint's. This needs to happen before the control plane agent is deployed with the changes that remove the old constraints. I think it would probably be best to do a separate PR / deploy for the dekaf changes first, much like has already been done for all the materialization connectors.
Separately...the materialize_soak connector from the tests/soak test will also need to be updated. That is a soak test that is manually run.
| )), | ||
| }) | ||
| .collect::<BTreeMap<_, _>>(); | ||
| .collect::<Vec<_>>(); |
Member
There was a problem hiding this comment.
nit: I think a bare collect() would work here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
constraintstoprojection_constraintsin validation: allow multiple constraints per projection #2977 and materialize-*: migrate constraints to projection_constraints connectors#4714 and materialize-boilerplate: set multiple constraints for projections connectors#4648constraintsfrom the protocolWorkflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)